Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anti join #59

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Anti join #59

merged 7 commits into from
Apr 25, 2024

Conversation

zander-prinsloo
Copy link
Collaborator

  1. Add anti join to the joyn() function
  2. Add dplyr-like anti_join()

Note, the update_values and update_NAs capabilities are removed because it does not make sense with an anti join.

All checks are passed.
image

Copy link
Owner

@randrescastaneda randrescastaneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @zander-prinsloo ,

I think the PR is correct. Thanks! Just a minor comment on one condition. Let me know if the comment is relevant. If not, please merge, and pump up the version to next devel version (the one with 9000+). You can do it using devtools::use_version() in case you did not know. Thank you!

R/joyn-merge.R Outdated
Comment on lines 306 to 307
if (keep == "semi" &
match_type == "m:m") stop(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this condition ok? I thought you had to remove "semi" rather than "anti"... Please disregard this comment is does not make sense.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @randrescastaneda , I believe what we are doing here works. However, even the condition of keep == "semi" is irrelevant because we do not yet allow semi joins for joyn::joyn(). I am going to remove this condition.

I did, however, add more tests for joyn() to test that the m:m anti join works since you identified this.

@zander-prinsloo zander-prinsloo merged commit 581b2dd into DEV Apr 25, 2024
7 checks passed
@zander-prinsloo zander-prinsloo deleted the anti_join branch April 25, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants