-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anti join #59
Anti join #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @zander-prinsloo ,
I think the PR is correct. Thanks! Just a minor comment on one condition. Let me know if the comment is relevant. If not, please merge, and pump up the version to next devel version (the one with 9000+). You can do it using devtools::use_version()
in case you did not know. Thank you!
R/joyn-merge.R
Outdated
if (keep == "semi" & | ||
match_type == "m:m") stop( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this condition ok? I thought you had to remove "semi"
rather than "anti"
... Please disregard this comment is does not make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @randrescastaneda , I believe what we are doing here works. However, even the condition of keep == "semi"
is irrelevant because we do not yet allow semi joins for joyn::joyn()
. I am going to remove this condition.
I did, however, add more tests for joyn()
to test that the m:m anti join works since you identified this.
joyn()
functionanti_join()
Note, the
update_values
andupdate_NAs
capabilities are removed because it does not make sense with an anti join.All checks are passed.
![image](https://private-user-images.githubusercontent.com/62433917/324555293-9d66dafe-1927-43d7-89bc-1270b9acbe65.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDQ5NTgsIm5iZiI6MTczOTI0NDY1OCwicGF0aCI6Ii82MjQzMzkxNy8zMjQ1NTUyOTMtOWQ2NmRhZmUtMTkyNy00M2Q3LTg5YmMtMTI3MGI5YWNiZTY1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAzMzA1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5NmRkOTkwYzdmOTAxN2I5MDU5YzA2ZDkzOGU5YzM1MGJjNzdiMjhmYWRjZWZlNjZlNWZlZDc0MTE5MTZmNzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.R5hshRGU18GbYwE_hjJBm0XygXEScmWTtsOEpjzI6NQ)