[Main] Ensure ssh connections are closed when command is done executing #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-ival
requested review from
bmdepesa,
caliskanugur and
igomez06
as code owners
Contributor
|
@git-ival this looks good, can we get backports down to v2.9? Then we can get them all merged. |
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Problem
The internal
nodespackage did not have defer calls to close the client and ssh sessions once execution was completed.Solution
Add these defer
.Close()calls.Testing
Have not tested on repos outside of
rancher/dartboard.Regressions Considerations
This should not lead to regressions as the added calls are deferred