Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for OCI registry based charts #975

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

thardeck
Copy link
Contributor

@thardeck thardeck commented Sep 15, 2022

until go-getter has native support we are using Helm for now to download the charts from OCI registries.

Authentication for the OCI registry is not supported yet.

Example fleet.yaml: rancher/fleet-examples#34

Fixes #191

@thardeck thardeck force-pushed the add_oci_helm_chart_support branch 3 times, most recently from 1243b70 to b0a8190 Compare September 15, 2022 13:02
@thardeck thardeck marked this pull request as ready for review September 15, 2022 13:55
@thardeck thardeck requested a review from a team as a code owner September 15, 2022 13:55
@thardeck thardeck self-assigned this Sep 15, 2022
@thardeck thardeck force-pushed the add_oci_helm_chart_support branch from b0a8190 to b0df19f Compare September 15, 2022 14:24
until go-getter has native support we are using Helm for now to download
the charts from OCI registries.

Authentication for the OCI registry is not supported yet.
@thardeck thardeck force-pushed the add_oci_helm_chart_support branch from b0df19f to 2a61a96 Compare September 16, 2022 04:31
instead of capitalizing and thus making them unintentional public.
manno
manno previously approved these changes Sep 16, 2022
Copy link
Member

@manno manno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add info about the version: field to the docs, but doesn't have to be in this PR.

@thardeck thardeck merged commit 941f0a5 into master Sep 16, 2022
@thardeck thardeck deleted the add_oci_helm_chart_support branch September 16, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support OCI Helm charts
2 participants