Feat/ipv6only #212
Open
Feat/ipv6only #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoral2
reviewed
Feb 6, 2025
fmoral2
reviewed
Feb 6, 2025
mdrahman-suse
force-pushed
the
feat/ipv6only
branch
from
087a40d to
0d63796
Compare
mdrahman-suse
force-pushed
the
feat/ipv6only
branch
5 times, most recently
from
008f906 to
9c71ec7
Compare
fmoral2
reviewed
Feb 10, 2025
| @@ -120,3 +120,4 @@ pre-commit: | |||
| @go vet ./... | |||
| @golangci-lint run --tests ./... | |||
| @shellcheck modules/airgap/setup/*.sh | |||
| @shellcheck modules/ipv6only/scripts/*.sh | |||
There was a problem hiding this comment.
can we create a make shell check ? just to not start getting bigger and bigger this one
fmoral2
reviewed
Feb 10, 2025
shared/airgap.go
Outdated
| // DisplayAirgapClusterDetails executes and prints kubectl get nodes,pods on bastion. | ||
| func DisplayAirgapClusterDetails(cluster *Cluster) { | ||
| // LogClusterDetailsViaProxy executes and prints kubectl get nodes,pods on bastion. | ||
| func LogClusterDetailsViaProxy(cluster *Cluster) { |
There was a problem hiding this comment.
can we name more accurately , idk something like LogClusterDetailsFromBastion ?
although it behaves like a proxy , but i think can bring confusion
fmoral2
reviewed
Feb 10, 2025
| func TestIPv6Only(cluster *shared.Cluster, awsClient *aws.Client) { | ||
| shared.LogLevel("info", "Setting up %s cluster on ipv6 only nodes...", cluster.Config.Product) | ||
| err := support.ConfigureIPv6OnlyNodes(cluster, awsClient) | ||
| Expect(err).NotTo(HaveOccurred(), err) |
There was a problem hiding this comment.
can we add a break line here? after your expect >?
fmoral2
reviewed
Feb 10, 2025
pkg/testcase/pod.go
Outdated
| // TestAirgapClusterPodStatus test the status of the pods in the private cluster using custom assert functions. | ||
| func TestAirgapClusterPodStatus( | ||
| // TestPodStatusViaProxy test the status of the pods in the private cluster using custom assert functions. | ||
| func TestPodStatusViaProxy( |
There was a problem hiding this comment.
same comment from Log via proxy
fmoral2
reviewed
Feb 10, 2025
pkg/testcase/node.go
Outdated
| // TestAirgapClusterNodeStatus test the status of the nodes in the private cluster using 2 custom assert functions. | ||
| func TestAirgapClusterNodeStatus( | ||
| // TestNodeStatusViaProxy test the status of the nodes in the private cluster using 2 custom assert functions. | ||
| func TestNodeStatusViaProxy( |
There was a problem hiding this comment.
same comment from Log via proxy
mdrahman-suse
force-pushed
the
feat/ipv6only
branch
3 times, most recently
from
28c9ee1 to
15b4391
Compare
mdrahman-suse
force-pushed
the
feat/ipv6only
branch
from
15b4391 to
ceae05d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Types of Changes
Testing
Checklist:
If your PR changes anything on or related to Jenkins, run it pointing to your branch to make sure it's okay.
Verify code lint; we should not have errors.
Update the documentation if needed.
Update makefile and docker run if adding new tests.
Run your tests at least 4 times with all configurations needed and possible.
If needed test with different os types.
Linked Issues
Further Comments