Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ernie.final.restore #199

Merged
merged 25 commits into from
Jan 20, 2025
Merged

Ernie.final.restore #199

merged 25 commits into from
Jan 20, 2025

Conversation

fmoral2
Copy link
Contributor

@fmoral2 fmoral2 commented Dec 10, 2024

Proposed Changes

- add restore snapshot to s3
 
- aws config refactored
- aws client split
- install cmd moved to shared 
- timeout added on k8s cluster healt
- retry added on product/manageservice func 
- new func created to add a new kubeconfig on local  - `NewLocalKubeconfigFile` .
- no sleeps added

Types of Changes

Testing

Checklist:

  1. If your PR changes anything on or related to Jenkins, run it pointing to your branch to make sure it's okay.

  2. Verify code lint; we should not have errors.

  3. Update the documentation if needed.

  4. Update makefile and docker run if adding new tests.

  5. Run your tests at least 4 times with all configurations needed and possible.

  6. If needed test with different os types.

Linked Issues

Further Comments

@fmoral2 fmoral2 force-pushed the ernie.final.restore branch 5 times, most recently from 11bb2f3 to afa1064 Compare December 10, 2024 15:20
@fmoral2 fmoral2 marked this pull request as ready for review December 10, 2024 15:29
@fmoral2 fmoral2 force-pushed the ernie.final.restore branch from afa1064 to 6fd2dad Compare December 10, 2024 15:31
@fmoral2 fmoral2 force-pushed the ernie.final.restore branch from 6fd2dad to 6fefe91 Compare December 10, 2024 17:42
docs/testing.md Outdated Show resolved Hide resolved
shared/product.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mdrahman-suse mdrahman-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

shared/product.go Outdated Show resolved Hide resolved
VestigeJ
VestigeJ previously approved these changes Dec 20, 2024
@fmoral2 fmoral2 force-pushed the ernie.final.restore branch 5 times, most recently from 351c3bd to 0525fc0 Compare December 31, 2024 13:46
@fmoral2 fmoral2 force-pushed the ernie.final.restore branch from 0525fc0 to ed60655 Compare December 31, 2024 13:48
shared/aux.go Outdated Show resolved Hide resolved
mdrahman-suse
mdrahman-suse previously approved these changes Jan 14, 2025
Copy link
Contributor

@mdrahman-suse mdrahman-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for addressing the comments

Signed-off-by: Francisco <[email protected]>
@fmoral2 fmoral2 force-pushed the ernie.final.restore branch from 423c624 to c15ee33 Compare January 16, 2025 14:50
@fmoral2 fmoral2 merged commit 83e207d into rancher:main Jan 20, 2025
1 check passed
aganesh-suse pushed a commit to aganesh-suse/distros-test-framework that referenced this pull request Feb 3, 2025
*  add cluster restore
---------

Signed-off-by: Francisco <[email protected]>
Co-authored-by: ERYN Dawkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants