-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ernie.final.restore #199
Merged
Merged
Ernie.final.restore #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francisco <[email protected]>
…stros-test-framework into ernie.final.restore
…stros-test-framework into ernie.final.restore
…stros-test-framework into ernie.final.restore
…ing rke2 using cni plugins
fmoral2
force-pushed
the
ernie.final.restore
branch
5 times, most recently
from
December 10, 2024 15:20
11bb2f3
to
afa1064
Compare
fmoral2
force-pushed
the
ernie.final.restore
branch
from
December 10, 2024 15:31
afa1064
to
6fd2dad
Compare
fmoral2
force-pushed
the
ernie.final.restore
branch
from
December 10, 2024 17:42
6fd2dad
to
6fefe91
Compare
mdrahman-suse
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
VestigeJ
previously approved these changes
Dec 20, 2024
fmoral2
force-pushed
the
ernie.final.restore
branch
5 times, most recently
from
December 31, 2024 13:46
351c3bd
to
0525fc0
Compare
fmoral2
force-pushed
the
ernie.final.restore
branch
from
December 31, 2024 13:48
0525fc0
to
ed60655
Compare
Signed-off-by: Francisco <[email protected]>
mdrahman-suse
previously approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for addressing the comments
fmoral2
force-pushed
the
ernie.final.restore
branch
from
January 16, 2025 12:28
a109dc5
to
423c624
Compare
Signed-off-by: Francisco <[email protected]>
fmoral2
force-pushed
the
ernie.final.restore
branch
from
January 16, 2025 14:50
423c624
to
c15ee33
Compare
mdrahman-suse
approved these changes
Jan 16, 2025
VestigeJ
approved these changes
Jan 17, 2025
aganesh-suse
pushed a commit
to aganesh-suse/distros-test-framework
that referenced
this pull request
Feb 3, 2025
* add cluster restore --------- Signed-off-by: Francisco <[email protected]> Co-authored-by: ERYN Dawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
refactor cfg dependency injection
fix this env vars stuff #160
next steps:
harden
snapshot not to s3
Types of Changes
Testing
Checklist:
If your PR changes anything on or related to Jenkins, run it pointing to your branch to make sure it's okay.
Verify code lint; we should not have errors.
Update the documentation if needed.
Update makefile and docker run if adding new tests.
Run your tests at least 4 times with all configurations needed and possible.
If needed test with different os types.
Linked Issues
Further Comments