Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 7, 2026

Summary

In read-only Config tab views, an empty footer with no buttons was consuming 60px of vertical space, hiding content at the bottom of the page.

Occurred changes and/or fixed issues

The CruResourceFooter component wrapper (.cru__footer) has a fixed 60px height. ConfigTab was only hiding the inner .cru-resource-footer element, leaving the outer wrapper still consuming space in view mode.

Updated ConfigTab CSS to hide both selectors:

:deep() .cru-resource-footer,
:deep() .cru__footer {
  display: none;
}

Technical notes summary

The CruResource component renders CruResourceFooter inside a wrapper div with class cru__footer that has height: $footer-height (60px). In view mode, the inner component content is conditionally hidden via v-if="!isView", but the wrapper element remains in the DOM.

Areas or cases that should be tested

  • Deployment detail page → Config tab (verify no footer space)
  • Any resource with custom create/edit forms → Config tab in detail view
  • Verify footer still displays correctly in create/edit modes
  • Test in both light and dark modes

Browser used for local testing: N/A (CSS-only change)

Areas which could experience regressions

  • Resources with custom create/edit forms that use CruResource component
  • ResourceDetailDrawer Config tab behavior
  • Any component that relies on .cru__footer visibility in view mode

Screenshot/Video

Before: Footer consuming space with no visible content
image

After: No space consumed by hidden footer

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
    • Triggering command: /usr/local/bin/node /usr/local/bin/node index.js --exec install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Read-only Config view shows empty footer, hiding content</issue_title>
<issue_description><!--------- For bugs and general issues --------->
Setup

  • Rancher version: v2.12.0 (dev of)

Describe the bug

  • Resources that have custom forms for creating and editing will show a Config tab in their detail view
  • This view is a 'read only' version of the create/edit page
  • The bottom of the page in create/edit mode has buttons in a footer
  • The footer of the page in view mode though still shows... but without buttons
  • The footer should not consumer space / be visible in view mode

To Reproduce

  • --> Deployment detail page --> Config tab

Result
as per screenshot

Expected Result
no space consumed by empty footer

Screenshots
Image

Additional context
found whilst reviewing #14475</issue_description>

<agent_instructions>Please make sure that the fixes comment in the PR references issue 14529</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Hide both .cru-resource-footer and .cru__footer in ConfigTab
- The .cru__footer wrapper has a fixed height that was still taking space even though the inner component was hidden
- Tests pass and linting passes

Fixes #14529

Co-authored-by: nwmac <[email protected]>
Copilot AI changed the title [WIP] Fix empty footer in read-only Config view Fix empty footer consuming space in read-only Config view Jan 7, 2026
Copilot AI requested a review from nwmac January 7, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read-only Config view shows empty footer, hiding content

2 participants