Wrap contents of Masthead/latest.vue in a div
#16269
Open
+23
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves the warning
[Vue warn]: Runtime directive used on component with non-element root node. The directives will not function as intended.by wrapping the contents ofshell/components/ResourceDetail/Masthead/latest.vuein adiv.Fixes #16248
Occurred changes and/or fixed issues
Masthead/latest.vuein a divTechnical notes summary
The warning appears to be originating from
v-ifusage inshell/components/ResourceDetail/Masthead/index.vue:dashboard/shell/components/ResourceDetail/Masthead/index.vue
Lines 47 to 51 in bac4bc1
The Vue3 docs don't contain any warnings that I could find with regards to
v-if/v-showusage on components with multiple root nodes. The best I could find while searching is a reddit thread that explains this behavior1.Full contents of the warning:
Areas or cases that should be tested
The masthead will need to render properly with the additional div in place.
Areas which could experience regressions
Rendering of the masthead could change.
Screenshot/Video
NA
Checklist
Admin,Standard UserandUser BaseFootnotes
https://www.reddit.com/r/vuejs/comments/17036bb/vuejs_bug_with_vshow_and_multiple_root_element/ ↩