Fix Vue warning for undefined 'dev' property in LocaleSelector #16211
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13851
Occurred changes and/or fixed issues
The LocaleSelector component accessed
this.devin computed properties without properly mapping it from the Vuex store, causing Vue to emit a warning when the locale selector was opened on the login page.Technical notes summary
Added
...mapGetters('prefs', ['dev'])to the component's computed properties. Thedevgetter already exists in the prefs store (lines 249-255 ofshell/store/prefs.js) but wasn't being mapped to the component.Before:
After:
Areas or cases that should be tested
Areas which could experience regressions
this.dev)this.devandprocess.env.dev)Screenshot/Video
N/A - console warning fix only, no visual changes
Checklist
Admin,Standard UserandUser BaseWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
download.cypress.io/usr/local/bin/node /usr/local/bin/node index.js --exec install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.