Skip to content

Conversation

@aalves08
Copy link
Member

@aalves08 aalves08 commented Dec 11, 2025

Summary

Fixes #13596

Occurred changes and/or fixed issues

  • update target of tsconfig in shell pkg

Technical notes summary

Areas or cases that should be tested

  • I gave it a test with Kubewarden and Elemental and both build and browsing through the extension looked fine to me

More tests to do:

  • Should be tested with Harvester/Longhorn @houhoucoop @a110605

  • Should be tested with CAPI/Virtual Clusters @eva-vashkevich @mantis-toboggan-md

  • Should be tested with Liz @torchiaf

  • yarn link the shell from this PR (add a console log to a known resource like ResourceTable so that you can check that yarn link worked fine when browsing the extension in a view with a table, or something similar)

  • Do a local build of the extension like yarn build-pkg ....

  • Do a developer load of the extension onto Rancher

  • Check that extension works fine

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@aalves08 aalves08 added this to the v2.14.0 milestone Dec 11, 2025
@aalves08 aalves08 self-assigned this Dec 11, 2025
@aalves08
Copy link
Member Author

FYI @richard-cox , playing around with tsconfig is NOT my strong suit

FYI @cnotv , although I tested with Kubewarden

@aalves08 aalves08 requested a review from torchiaf December 11, 2025 11:51
@aalves08
Copy link
Member Author

aalves08 commented Dec 11, 2025

Have to move this to draft since the gates for ALL e2e tests are failing with: https://github.com/rancher/dashboard/actions/runs/20133417185/job/57780514802?pr=16155

Don't even know where to start debugging this... extension build is fine and I also ran a yarn build on Dashboard and compiled fine...

Please refrain from doing any tests on your extensions until this is sorted. Thank you! 🙏

@aalves08 aalves08 marked this pull request as draft December 11, 2025 14:33
@cnotv
Copy link
Member

cnotv commented Dec 11, 2025

Have to move this to draft since the gates for ALL e2e tests are failing with: https://github.com/rancher/dashboard/actions/runs/20133417185/job/57780514802?pr=16155

Don't even know where to start debugging this... extension build is fine and I also ran a yarn build on Dashboard and compiled fine...

Please refrain from doing any tests on your extensions until this is sorted. Thank you! 🙏

It seems like changing target for ES module is transpiling something which is now different at the moment of the authentication

Screenshot 2025-12-11 at 17 18 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tech debt: Inconsistent tsconfig between Dashboard and UI Extension

2 participants