Skip to content

Conversation

@aalves08
Copy link
Member

@aalves08 aalves08 commented Dec 10, 2025

Summary

Fixes #15645

Occurred changes and/or fixed issues

  • adds logic for gating routes that aren't registered, preventing access to said pages. Especially useful for builtin extensions like SCC
  • adds unit tests

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@aalves08 aalves08 self-assigned this Dec 10, 2025
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.14.0 milestone Dec 10, 2025
@aalves08 aalves08 requested a review from richard-cox December 22, 2025 17:30
@aalves08 aalves08 force-pushed the 15645-gate-extension-routes branch from a358558 to f8aded0 Compare December 22, 2025 17:30
@aalves08 aalves08 marked this pull request as ready for review December 22, 2025 17:30
@aalves08 aalves08 marked this pull request as draft December 23, 2025 15:04
@aalves08
Copy link
Member Author

Back to draft since this is making e2e tests fail... needs investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tech debt: Gate the addRoutes for extensions to follow the same conditions as configureType/virtualType

1 participant