[k6] More tests for vai and UI testing#98
Conversation
5d1f690 to
76878f2
Compare
0b3be40 to
fd19535
Compare
There was a problem hiding this comment.
Looks good but I have some thoughts mostly around the code structure. I think we should try and make the functions in the utils as generic as possible.
To that end, maybe we have the metadata and data be separate parameters to our util functions for API requests like these (see the secrets-oriented functions for example). That way you can pass in any valid metadata + data and have it work™️. I think we would also want to default to the currently hardcoded defaults if they are not passed in*
|
Nitpick: can we rename the functions in It would also be good to return the |
57caeaf to
52034ce
Compare
No description provided.