Fix release record preflight - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
permissions.pushassertion from the production release-record preflight.git push --dry-runas the actual write-capability test.EXITtrap so the temporary local preflight tag is deleted whether the dry run succeeds or fails.Why
Release-train run
30390248001completed qualification, image build, rehearsal, rollback verification, candidate staging promotion, and legal-source checks, then failed before production becausegh api repos/... --jq '.permissions.push'returned a value other thantrueeven though the job token hadcontents: write.Impact
The release train will now gate production on the real tag-push dry run instead of an unreliable metadata field. No production application behavior is changed by this PR.
Validation
.github/workflows/verify-and-deploy-public-beta.yml.contents: writejob permission remains unchanged.