-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow better ticket channel name customisation #93
Conversation
I'm pretty sure these are everything I need to change but lmk if I missed any places I needed to add this change as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imLuckii, thank you for your contribution!
This is definitely a good change since it allows better customization of the ticket channel names, though I think the default option you put is a bit too long for most users so before merging this PR I'd appreciate it if you can make the default option fallback to CATEGORY-TICKETCOUNT
(${category.name}-{TICKETCOUNT}
) which is also the default channel name for most ticket bots.
This is great improvement, in the future I may consider redoing ticket channel names to make it even more customizable but this will do well for now, thanks again!
I've made the changes you requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, following the merge of this PR I'll add a minor fix to the code so that lowercase or uppercase does not matter anymore in the ticket names since I noticed it was also an issue previously, your commit pointed me towards this now, I appreciate that.
Glad to have helped |
Pretty self-explanatory but here are the new options
CATEGORY-USERNAME
(will be called category-USERNAME such as general-ralphkb)CATEGORY-TICKETCOUNT
(will be called category-TICKETCOUNT such as general-12348)USERNAME-TICKETCOUNT
(will be called USERNAME-TICKETCOUNT such as ralphkb-12348)USERNAME-CATEGORY
(will be called USERNAME-category such as ralphkb-general)USERNAME-CATEGORY-TICKETCOUNT
(will be called USERNAME-category-TICKETCOUNT such as ralphkb-general-12348)DEFAULT
(will be called category-USERNAME-TICKETCOUNT such as general-ralphkb-12348)Let me know if you like any changes. I understand this might not get implemented as it'll break the config when existing user upgrade, but, most likely they'll adapt to this and it'll help new users have a better customisation of the ticket channel name as when I started using the bot, I had to manually add these options.