Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE REQUEST] Translate to French #14

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Conversation

OverStyleFR
Copy link
Contributor

Hi,

There is a version of config.yml and the README translate to French.

⚠️The command /panel don't work on my bot ⚠️

There is the screenshot bellow, no error on the console.
image

He start correctly :
image
image

@mrkingtj
Copy link

The issue with /panel would either be bad config or an error in panel.js. There is no debug logging but if you ask GBT to insert logging without modifying code structure then rerun it can help.
I heavily advise to keep a fresh copy of panel.js from this repository. If you fix the issue I advise to remove all the debug console logging from the file

@OverStyleFR
Copy link
Contributor Author

The issue with /panel would either be bad config or an error in panel.js. There is no debug logging but if you ask GBT to insert logging without modifying code structure then rerun it can help. I heavily advise to keep a fresh copy of panel.js from this repository. If you fix the issue I advise to remove all the debug console logging from the file

No i don't think it's an error with panel.js i use this version of the bot on 2 discord server and no bug there.
I don't want to start to modify the panel.js to risky for me, i'm not a JS developer 😅

@mrkingtj
Copy link

I advise to add logging to the panel.js file. Make a copy of your original and put on your desktop or somewhere then get GBt to add logging to it all. If that breaks then you always have a copy of the original there.

If that doesn't work then i would recommend going over config.yml thoroughly. Noticing the bot not responding to the command but the bot being online indicates the command didnt fire. Usually invalid object/variable that isnt in a try...catch statement. Everything is fine for me apart from unknown interaction but can be fixed by adding interaction.deferReply() and replacing interaction.reply with interaction.editReply

@OverStyleFR
Copy link
Contributor Author

I advise to add logging to the panel.js file. Make a copy of your original and put on your desktop or somewhere then get GBt to add logging to it all. If that breaks then you always have a copy of the original there.

If that doesn't work then i would recommend going over config.yml thoroughly. Noticing the bot not responding to the command but the bot being online indicates the command didnt fire. Usually invalid object/variable that isnt in a try...catch statement. Everything is fine for me apart from unknown interaction but can be fixed by adding interaction.deferReply() and replacing interaction.reply with interaction.editReply

Don't need to do all of that. I just make a simple test :

  • Copy the original file config.yml
  • Copy the general ID for run correctly the bot
  • Now execute /panel

And it's worked !
image
So it's a problem cause by my translation, i think ChatGPT go wrong when he translate the file.
I'm gonna figure out what is the problem and solve it.

@OverStyleFR
Copy link
Contributor Author

Problem solve by the latest commit.

Everything works, ready for merge. @ralphkb

Copy link
Owner

@ralphkb ralphkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for contributing, this new lang directory will be useful in case the bot gets more translations in the future then they could be added to it.

@ralphkb ralphkb merged commit 0280ca1 into ralphkb:main Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants