Add duration serializer, deserializer #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergercookie
force-pushed
the
develop
branch
3 times, most recently
from
4991426 to
bea58c8
Compare
…ests under the cloned taskwarrior/ project during CI
bergercookie
force-pushed
the
develop
branch
3 times, most recently
from
91e37f2 to
8e63c27
Compare
…rk to handle values like "monthly" and "daily
|
I hadn't realised that a duration field may be presented in formats other than the ISO8601, e.g., I would suggest that we keep this PR contained and handle these extra fields in a separate PR and line of work. For now I'm keeping the Unittests pass so it's ready to merge from my side. Thoughts? |
This was referenced May 29, 2022
|
@ralphbean, @coddingtonbear do you have some time to skim through this PR? |
|
Can I please get some eyes on this one ? |
bergercookie
added a commit
to bergercookie/syncall
that referenced
this pull request
Jan 29, 2024
It's now part of the taskw_ng repo so we shouldn't make the serialization/deserialization twice Effectively fixes the upstream issue: ralphbean/taskw#160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ralphbean ,
This PR adds serdes functions for the Duration class. I decided to implement them in taskwarrior_syncall so I thought of pushing them to this project ^^
Additional changes:
setup.cfg.make -jto speed up the CI process