Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc.verbose=new-uuid only works if it is the first paramater for taskwarrior 2.5.2 #141

Closed
wants to merge 1 commit into from

Conversation

EdwardBetts
Copy link
Contributor

There is a bug in version of taskwarrior that the rc.verbose=new-uuid argument will only work if it is the first argument.

See GothenburgBitFactory/taskwarrior#1953

This change moves the 'verbose' config option to be first in DEFAULT_CONFIG_OVERRIDES.

Without this change the test suite fails and it isn't possible to create new tasks.

There is a bug in version of taskwarrior that the rc.verbose=new-uuid
argument will only work if it is the first argument.

GothenburgBitFactory/taskwarrior#1953

This change moves the 'verbose' config option to be first in
DEFAULT_CONFIG_OVERRIDES.

Without this change the test suite fails and it isn't possible to create
new tasks.
@@ -412,10 +412,10 @@ class TaskWarriorShellout(TaskWarriorBase):
and https://github.com/ralphbean/taskw/issues/30 for more.
"""
DEFAULT_CONFIG_OVERRIDES = {
'verbose': 'nothing',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, dictionaries aren't ordered by insertion order in Python < 3.7; so I'm afraid this doesn't quite work unless you also change this to be a collections.OrderedDict instance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.6 support ends in 7 months (23 Dec 2021). So while incomplete, this simple change fixes taskw for majority of supported Python versions.

@jayvdb
Copy link
Contributor

jayvdb commented Mar 10, 2021

When I use this for the tests on Python 3.8, it lets 37 extra tests pass, but 10 tests still fail.

@EdwardBetts
Copy link
Contributor Author

@jayvdb: It took me three patches to make taskw build without any test failures.

Patches are here: https://salsa.debian.org/python-team/packages/taskw/-/tree/debian/master/debian/patches

@bergercookie
Copy link
Contributor

I also stumbled upon the same issue and solved it by parsing the ID from stdout instead of the UUID.
It's interesting to note that the verbose.new-uuid is now supported only for TW >= 2.6.0 according to this page:

https://taskwarrior.org/docs/verbosity.html
bergercookie/taskw-ng@8e1235d

@BlackYoup
Copy link

Hello, is there anything to do to help get this merged? I believe proposing a different patch according to the review that was emitted?

It's interesting to note that the verbose.new-uuid is now supported only for TW >= 2.6.0 according to this page:

It seems like it's in the code base of v2.5.3 when parsing the verbosity so it may only be a documentation problem? https://github.com/GothenburgBitFactory/taskwarrior/blob/2f47226f91f0b02f7617912175274d9eed85924f/src/Context.cpp#L953

@ralphbean
Copy link
Owner

Merging in #147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants