Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Description as Positional Argument #135

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Pass Description as Positional Argument #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion taskw/test/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,22 +105,25 @@ def test_ordering(self):

def test_taskwarrior_null_encoding_bug_workaround(self):
task = {
'description': 'arbitrary description',
'priority': ''
}
actual_encoded = encode_task_experimental(task)[0]
actual_encoded = encode_task_experimental(task)[1]
expected_encoded = "priority:"

assert actual_encoded == expected_encoded

def test_encodes_dates(self):
arbitrary_date = datetime.date(2014, 3, 2)
task = {
'description': 'arbitrary description',
'arbitrary_field': arbitrary_date
}

actual_encoded_task = encode_task_experimental(task)
expected_encoded_task = encode_task_experimental(
{
'description': 'arbitrary description',
'arbitrary_field': arbitrary_date.strftime(DATE_FORMAT)
}
)
Expand All @@ -130,12 +133,14 @@ def test_encodes_dates(self):
def test_encodes_naive_datetimes(self):
arbitrary_naive_datetime = datetime.datetime.now()
task = {
'description': 'arbitrary description',
'arbitrary_field': arbitrary_naive_datetime
}

actual_encoded_task = encode_task_experimental(task)
expected_encoded_task = encode_task_experimental(
{
'description': 'arbitrary description',
'arbitrary_field': (
arbitrary_naive_datetime
.replace(tzinfo=dateutil.tz.tzlocal())
Expand All @@ -152,12 +157,14 @@ def test_encodes_zoned_datetimes(self):
tzinfo=arbitrary_timezone
)
task = {
'description': 'arbitrary description',
'arbitrary_field': arbitrary_zoned_datetime
}

actual_encoded_task = encode_task_experimental(task)
expected_encoded_task = encode_task_experimental(
{
'description': 'arbitrary description',
'arbitrary_field': (
arbitrary_zoned_datetime
.astimezone(pytz.utc).strftime(DATE_FORMAT)
Expand Down
9 changes: 9 additions & 0 deletions taskw/test/test_warrior.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,12 @@ def test_add_task_recurs(self):
assert tasks['pending'][0]['recur'] == 'weekly'
assert tasks['pending'][0]['parent'] is not None

def test_add_task_depends_keyword(self):
"""Add a task with description beginning with keyword "depends".
See https://github.com/ralphbean/bugwarrior/issues/733.
"""
self.taskwarrior.task_add('depends filter does not work with IDs')
tasks = self.taskwarrior.load_tasks()
assert len(tasks['pending']) == 1
assert (tasks['pending'][0]['description']
== 'depends filter does not work with IDs')
3 changes: 2 additions & 1 deletion taskw/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ def encode_task_experimental(task):
task[k] = encode_task_value(k, task[k])

# Then, format it as a string
return [
positionals = [task.pop('description')] if 'description' in task else []
return positionals + [
"%s:\"%s\"" % (k, v) if v else "%s:" % (k, )
for k, v in sorted(task.items(), key=itemgetter(0))
]
Expand Down