Skip to content

warrior.py: Fix Python 3 detecting missing task #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 19, 2019

Replaces 'foo' in e with 'foo' in str(e).

Fixes #127

Replaces `'foo' in e` with `'foo' in str(e)`.

Fixes ralphbean#127
@coddingtonbear
Copy link
Collaborator

Actually, I think #130 solves this same problem, just in a slightly more pythonic way. Thanks for your patch, though!

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 8, 2020

fwiw, it was intentional to not do it that way. The other approach broke Python 2.
#130 (comment)
Can be fixed using something like https://stackoverflow.com/questions/21367320/searching-for-equivalent-of-filenotfounderror-in-python-2 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: argument of type 'FileNotFoundError' is not iterable
2 participants