Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement endpoint for deleting images by entity ID #117

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

VKTB
Copy link
Collaborator

@VKTB VKTB commented Feb 11, 2025

Description

This PR implements a DELETE endpoint at /images that accepts an entity_id query parameter and deletes all images with that entity_id.

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Successfully deletes all images associated with the supplied entity_id
  • Returns 204 if entity_id is invalid or not associated with any images

Agile board tracking

closes #104

@VKTB VKTB changed the title Implement endpoint for deleting attachments by entity ID Implement endpoint for deleting images by entity ID Feb 11, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.44%. Comparing base (d48a3bc) to head (7d5826f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
+ Coverage    99.42%   99.44%   +0.01%     
===========================================
  Files           19       19              
  Lines          519      537      +18     
===========================================
+ Hits           516      534      +18     
  Misses           3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from endpoint-for-deleting-attachments-by-entity-id-#76 to develop February 13, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an endpoint for deleting images by entity ID
2 participants