Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an endpoint for deleting images by entity ID #104

Open
2 tasks
VKTB opened this issue Jan 29, 2025 · 0 comments · May be fixed by #117
Open
2 tasks

Add an endpoint for deleting images by entity ID #104

VKTB opened this issue Jan 29, 2025 · 0 comments · May be fixed by #117
Assignees
@VKTB
Labels
enhancement New feature or request

Comments

@VKTB
Copy link
Collaborator

VKTB commented Jan 29, 2025

Dependent on #38. This endpoint should be a DELETE with a entity_id query parameter at /images that:

  • Deletes all images with that entity_id
  • Returns 204 if the entity_id is invalid or is not associated with any images

Will need consideration on how to deal with errors mid way, I expect they can be mitigated by deleting the database documents after successful deletion from the object store like we already do for the others.
@VKTB VKTB added the enhancement New feature or request label Jan 29, 2025
@VKTB VKTB self-assigned this Jan 29, 2025
@VKTB VKTB moved this to To Do On This Sprint in Inventory Management System Jan 29, 2025
@VKTB VKTB moved this from To Do On This Sprint to In Progress in Inventory Management System Jan 29, 2025
VKTB added a commit that referenced this issue Feb 11, 2025
@VKTB
Implement repo method for deleting images by entity ID #104
de02a24
VKTB added a commit that referenced this issue Feb 11, 2025
@VKTB
Implement store method for deleting images by entity ID #104
b53ac15
VKTB added a commit that referenced this issue Feb 11, 2025
@VKTB
Implement service method for deleting images by entity ID #104
3e31db9
VKTB added a commit that referenced this issue Feb 11, 2025
@VKTB
Implement endpoint for deleting images by entity ID #104
88f10b0
VKTB added a commit that referenced this issue Feb 11, 2025
@VKTB
Write unit tests for new repo method #104
df1c2b0
VKTB added a commit that referenced this issue Feb 11, 2025
@VKTB
Write unit tests for new store method #104
6480936
VKTB added a commit that referenced this issue Feb 11, 2025
@VKTB
Write unit tests for new service method #104
141b7cf
VKTB added a commit that referenced this issue Feb 11, 2025
@VKTB
Write e2e tests for new endpoint #104
d4ce2d1
@VKTB VKTB linked a pull request Feb 11, 2025 that will close this issue
Open
5 tasks
@VKTB VKTB moved this from In Progress to In Review in Inventory Management System Feb 11, 2025
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Merge branch 'develop' into endpoint-for-deleting-images-by-entity-id-#…
4c2ff32 
…104
VKTB added a commit that referenced this issue Feb 13, 2025
@VKTB
Remove default value for mock_get method #104
7d5826f
@VKTB VKTB mentioned this issue Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VKTB VKTB

Labels
enhancement New feature or request
Projects
Inventory Management System
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement endpoint for deleting images by entity ID ral-facilities/object-storage-api
1 participant
@VKTB