-
Notifications
You must be signed in to change notification settings - Fork 46
Support X509Certificate
in INI and HIA request
#168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally ok. I left some comments for which I would suggest a bit of refactoring. I have no EBICS access with which I could test it.
In case where certificates are being used, it should either be all or nothing. Therefore we should probably validate for that.
We probably also do not need to keep all 3 as attr_accessor variables on the client.
The most important piece that is missing here are usage examples for the README.
Without that, the change is not really complete for something as specific as this.
I would not expect anyone to figure it out by reading the code unless they know that it is already an available feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also tested at least file download on EBICS 2.5 still working (the primary use case that I have and can easily test)
The primary thing that is keeping me from merging this right now is #154, as bringing those together again might be a larger change and change the interface
Hi @tobischo |
This PR adds support for using x509 self-signed certificates in INI and HIA requests.
Details
init_letter
to use certificate data instead of a,x and e keys.debug_mode: boolean
option to client initialization, allowing easy logging of requests and responses for debugging purposes. When debug_mode is enabled, Faraday’s logger middleware is activated to output request and response bodies to STDOUTImpact
The changes are tested on plenty of 🇫🇷 banks: BNP, HSBC, Société Générale, LCL.
EBICS - Guide de mise en œuvre en France