Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t force cable.yml config #55

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

jkostolansky
Copy link
Contributor

I was just migrating a Rails app to Solid Trifecta, and I noticed an inconsistency in the installation process. Solid Cache and Solid Queue asked me if I wanted to overwrite my existing config files, but Solid Cable did not, it replaced the already manually edited config.yml file without asking.

If there isn't any other reason to keep the force option enabled, I propose that we disable it.

Relevant files:

@npezza93 npezza93 merged commit 7cce173 into rails:main Jan 10, 2025
4 checks passed
@jeromedalbert
Copy link

jeromedalbert commented Jan 25, 2025

I believe this PR introduces a regression in that it now blocks rails new as of yesterday's 3.0.6 release. Steps to repro:

$ rails new myapp

...
    conflict  config/cable.yml
Overwrite /Users/jerome/c/tmp/myapp/config/cable.yml? (enter "h" for help) [Ynaqdhm]

@npezza93 Should this be hotfixed/reverted and a new version released while deciding a better course of action, or what do you recommend?

npezza93 added a commit that referenced this pull request Jan 25, 2025
@npezza93
Copy link
Collaborator

npezza93 commented Jan 25, 2025

Ugh yea good catch @jeromedalbert. I've reverted and cut a new release. @jkostolansky looks like we cant do this because rails currently manages the cable.yml file on creation. Whereas it does control cache.yml and queue.yml for the other solids. Thanks again for catching @jeromedalbert

@jeromedalbert
Copy link

jeromedalbert commented Jan 25, 2025

Thank you for the super quick revert @npezza93! ❤️

Wondering if maybe the fix would be for Rails to skip creating cable.yml if solid is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants