Skip to content

Add the ability to pass through the keepalive configuration option #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

brendon
Copy link
Contributor

@brendon brendon commented Mar 8, 2025

I have a few concerns:

  • We're hard coding the current defaults for fetch for many options. Why not just omit passing them if they're not passed in?
  • It might be more future proof to allow any options to be passed in, and just override those specific options like contentType and headers as needed.

The solution to those is a much larger change, so for now just allowing keepalive through solves my immediate use-case.

Closes #85

@brendon
Copy link
Contributor Author

brendon commented Mar 8, 2025

CI needs some fixing :)

@t27duck t27duck mentioned this pull request Apr 27, 2025
@marcelolx
Copy link
Collaborator

@brendon do you mind rebasing from main now that #88 has been merged?

I am fine with us going only with keepalive for now and then later support customizing all other options

@brendon
Copy link
Contributor Author

brendon commented Apr 28, 2025

Hi @marcelolx, all done :)

@marcelolx marcelolx merged commit 4af88a8 into rails:main Apr 28, 2025
1 check passed
@brendon
Copy link
Contributor Author

brendon commented Apr 29, 2025

Hi @marcelolx, would you mind cutting a new release with this fix in it? :)

@marcelolx
Copy link
Collaborator

Done @brendon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would you consider adding support for custom fetch options?
2 participants