Automatically ci-skip if all changed files are md #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, documentation changes require contributors to add a variation of "ci skip" to their pull request in order to not run the full Rails test suite. However, it requires contributors to know about this feature in order to use it (to get faster/less flaky builds). This commit tries to remove the requirements of that knowledge by automatically skipping the full test suite in some cases (currently when all changed files are markdown). It also introduces a new opt-out "ci full" which can be used in cases where the automatic opt-out is undesired for some reason.
|
Opening the PR as a proof of concept/for feedback, but I still need to figure out how to test this. |
|
Happy to help test it, maybe we can 🍐 sometime :) |
|
Should we skip everything? The markdown linters and the guides inspector should still run, no? |
Those tasks are defined above this block so they should still run. (This should be equivalent to what adding [ci skip] does currently, it just happens automatically instead) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, documentation changes require contributors to add a variation of "ci skip" to their pull request in order to not run the full Rails test suite. However, it requires contributors to know about this feature in order to use it (to get faster/less flaky builds).
This commit tries to remove the requirements of that knowledge by automatically skipping the full test suite in some cases (currently when all changed files are markdown).
It also introduces a new opt-out "ci full" which can be used in cases where the automatic opt-out is undesired for some reason.