Skip to content

has_many: support chaining where clauses #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

has_many: support chaining where clauses #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_resource/associations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def defines_has_many_finder_method(reflection)
elsif attributes.include?(method_name)
attributes[method_name]
elsif !new_record?
instance_variable_set(ivar_name, reflection.klass.find(:all, params: { "#{self.class.element_name}_id": self.id }))
instance_variable_set(ivar_name, reflection.klass.all(params: { "#{self.class.element_name}_id": self.id }))
Copy link
Contributor Author

@seanpdoyle seanpdoyle Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, this could use .where

Suggested change
instance_variable_set(ivar_name, reflection.klass.all(params: { "#{self.class.element_name}_id": self.id }))
instance_variable_set(ivar_name, reflection.klass.where("#{self.class.element_name}_id": self.id))

else
instance_variable_set(ivar_name, self.class.collection_parser.new)
end
Expand Down
18 changes: 18 additions & 0 deletions test/cases/association_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,24 @@ def test_association_class_build
def test_has_many
External::Person.send(:has_many, :people)
assert_equal 1, External::Person.reflections.select { |name, reflection| reflection.macro.eql?(:has_many) }.count

ActiveResource::HttpMock.respond_to.get "/people.json?person_id=1", {}, { people: [ { id: 2, name: "Related" } ] }.to_json
person = External::Person.new({ id: 1 }, true)

people = person.people

assert_equal [ "Related" ], people.map(&:name)
end

def test_has_many_chain
External::Person.send(:has_many, :people)

ActiveResource::HttpMock.respond_to.get "/people.json?name=Related&person_id=1", {}, { people: [ { id: 2, name: "Related" } ] }.to_json
person = External::Person.new({ id: 1 }, true)

people = person.people.where(name: "Related")

assert_equal [ "Related" ], people.map(&:name)
end

def test_has_many_on_new_record
Expand Down