fix caches_action with layout false #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, I've encountered the same issue. |
antulik
added a commit
to antulik/actionpack-action_caching
that referenced
this pull request
May 27, 2017
|
+1 merge it! |
|
^ Agree, its much needed fix (forces us to fork the gem) |
|
This is a very serious bug that got fixed by #43 but the team hasn't uploaded the fix into RubyGems. If anyone is still having this issue just use github as the source for the gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I set
caches_action :home, layout: falseand the cache is not created, my action return a string that is not safe!I added html_safe method, which is also used in http://apidock.com/rails/ActionController/Caching/Fragments/read_fragment