Skip to content

Ensure pre-7.1 migrations use legacy index names when using rename_table #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2024
Merged

Ensure pre-7.1 migrations use legacy index names when using rename_table #1175

merged 1 commit into from
May 16, 2024

Conversation

aidanharan
Copy link
Contributor

Implemented change made in rails/rails#50837

Fixes the ActiveRecord::Migration::CompatibilityTest#test_rename_table_errors_on_too_long_index_name_7_0 test.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9109903293/job/25043759601?pr=1174

 24) Failure:
ActiveRecord::Migration::CompatibilityTest#test_rename_table_errors_on_too_long_index_name_7_0 [/usr/local/bundle/bundler/gems/rails-f92c8a3539ee/activerecord/test/cases/migration/compatibility_test.rb:434]:
StandardError expected but nothing was raised.

@aidanharan aidanharan marked this pull request as ready for review May 16, 2024 09:54
@aidanharan aidanharan merged commit 86851d3 into main May 16, 2024
2 of 8 checks passed
@aidanharan aidanharan deleted the fix-rename_table-for-indexes-7-0 branch May 16, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan