Skip to content

Add row_count field to sql.active_record notification #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2024
Merged

Add row_count field to sql.active_record notification #1169

merged 2 commits into from
May 13, 2024

Conversation

aidanharan
Copy link
Contributor

@aidanharan aidanharan commented May 10, 2024 •
edited
Loading

Fix:

  • ActiveRecord::InstrumentationTest#test_payload_row_count_on_pluck
  • ActiveRecord::InstrumentationTest#test_payload_row_count_on_raw_sql

See rails/rails#50887

@aidanharan aidanharan marked this pull request as ready for review May 13, 2024 10:17
@aidanharan aidanharan merged commit e7880d0 into main May 13, 2024
2 of 8 checks passed
@aidanharan aidanharan deleted the row-count-notification branch May 13, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan