feat: Add config option for turbine power generation multiplier#364
Open
vgeary96 wants to merge 4 commits into
Open
feat: Add config option for turbine power generation multiplier#364vgeary96 wants to merge 4 commits into
vgeary96 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly copied from #322
The Issue
#201
The Proposal
This adds a config option in railcraft-server.toml that allows users to modify the amount of RF a steam turbine generates
Possible Side Effects
I had to change the SteamTurbineBlock::getChargeSpecs method to construct a new object to allow for the config option to affect the RF the turbine outputs as well as generates; additionally, this adds a call to query the config each tick in the SteamTurbineBlockEntity class. The config is already being queried each tick in other spots, like in the steam boiler classes, so I decided it was a negligible side effect. This is an avenue of optimization in the future, if necessary.
Alternatives
Just boosting the turbine power generation across the board is both less configurable and could ruin the balance of other energy consumers in the mod.