WIP [explicit video refs] new server #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdiab
force-pushed
the
osdiab/feature/explicit-video-refs-new-server
branch
2 times, most recently
from
5ba0541 to
b46c737
Compare
…, additional MemberToBeCreated type
…in the legacy case
osdiab
force-pushed
the
osdiab/feature/explicit-video-refs-new-server
branch
from
ca895ef to
84f3780
Compare
… in raha google cloud storage, clearer wording on infrastructure specificity of the code
markulrich
reviewed
Nov 5, 2018
| "@types/big.js": "^4.0.4", | ||
| "@types/url-join": "^0.8.2", | ||
| "big.js": "^5.0.3", | ||
| "crypto-random-string": "^1.0.0", |
Member
There was a problem hiding this comment.
This package appears to be all of one line, can we just use said line https://github.com/sindresorhus/crypto-random-string/blob/master/index.js#L9 and avoid yet another external dep?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.