explicit video refs: shared operations, models, route shapes #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinaroh
approved these changes
Oct 30, 2018
Member
tinaroh
left a comment
tinaroh
left a comment
There was a problem hiding this comment.
if we're doing legacy route, lgtm
osdiab
force-pushed
the
osdiab/feature/explicit-video-refs-shared-models
branch
from
0e5fc0a to
ad48b25
Compare
osdiab
force-pushed
the
osdiab/feature/explicit-video-refs-shared-models
branch
from
f1e2109 to
782072f
Compare
…, additional MemberToBeCreated type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #128 for simplicity of handing backwards compatibility.
Updates to shared library to support explicit video urls. Supports endpoints being either current version ones, or legacy ones.
Doesn't merge into
master, merges into aexplicit-video-refsbranch; so feel free to review/approve and merge now.