Stop expanded Crime charts from stretching - #46
Open
raederhans wants to merge 1 commit into
Open
Conversation
Responsive Chart.js canvases used maintainAspectRatio=false inside auto-height containers. Opening the details disclosure created a parent-child resize feedback loop that stretched every chart and its axes indefinitely. Give each canvas a dedicated bounded sizing frame while retaining responsive width and extra height for the dense Top-N chart. Constraint: Preserve chart data, progressive disclosure, and mobile scrolling behavior. Rejected: Re-enable automatic aspect ratios | It would compress the dense horizontal Top-N chart and couple chart height to drawer width. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Responsive charts with maintainAspectRatio=false require an independently bounded parent. Tested: VITE_FEATURE_DIARY=1 VITE_TRACT_CRIME_SNAPSHOT=1 npm run validate; browser smoke; live 5.5-second size sampling; npm audit --audit-level=high
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The three responsive Chart.js canvases used maintainAspectRatio=false inside auto-height parents. Expanding the details disclosure caused the parent height and canvas height to feed each other through responsive resize observation, growing every chart and its axes indefinitely.
Fix
Verification
Boundaries