Add opt-in periodic py-spy dumper for hang debugging#1461
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23 and
yueming-yuan
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-ft-random-and-realistic-gsm8k-e2e-scenarios-with-periodic-fault
branch
from
b7e6ecd to
2d279bb
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-opt-in-periodic-py-spy-dumper-for-hang-debugging
branch
from
3fa4cfe to
581446a
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-ft-random-and-realistic-gsm8k-e2e-scenarios-with-periodic-fault
branch
from
2d279bb to
d360f8b
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-opt-in-periodic-py-spy-dumper-for-hang-debugging
branch
from
581446a to
eac9c88
Compare
Add miles/utils/debug_utils/periodic_py_spy.py and start it from the train entrypoints (train.py / train_async.py). Opt-in via MILES_DEBUG_PYSPY_DUMP_INTERVAL (no-op when unset); a background thread periodically py-spy-dumps the python/ray/sglang processes. Independent of fault tolerance.
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-ft-random-and-realistic-gsm8k-e2e-scenarios-with-periodic-fault
branch
from
d360f8b to
505352b
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-opt-in-periodic-py-spy-dumper-for-hang-debugging
branch
from
eac9c88 to
b05a02e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add miles/utils/debug_utils/periodic_py_spy.py and start it from the train
entrypoints (train.py / train_async.py). Opt-in via MILES_DEBUG_PYSPY_DUMP_INTERVAL
(no-op when unset); a background thread periodically py-spy-dumps the
python/ray/sglang processes. Independent of fault tolerance.