Add FT e2e test framework (conftest_ft harness)#1456
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-debug-exit-after-rollout-to-train-entrypoints
branch
from
5e920bf to
fbb0a45
Compare
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-ft-e2e-test-framework-conftest-ft-harness
branch
from
e052811 to
066e55d
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-debug-exit-after-rollout-to-train-entrypoints
branch
from
fbb0a45 to
cafb154
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-ft-e2e-test-framework-conftest-ft-harness
branch
from
066e55d to
04e0d23
Compare
Adds the shared FT e2e harness under tests/e2e/ft/conftest_ft/: mode resolution (modes.py: FTTestMode / resolve_mode / parallelism configs), training execution (execution.py: get_common_train_args / get_ft_args / prepare / run_training), and the comparison app driver (app.py: create_comparison_app_and_run_ci / resolve_dump_dir) plus the package README. All FT e2e scenarios build on this harness.
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-debug-exit-after-rollout-to-train-entrypoints
branch
from
cafb154 to
14dda88
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/add-ft-e2e-test-framework-conftest-ft-harness
branch
from
04e0d23 to
06d9275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the shared FT e2e harness under tests/e2e/ft/conftest_ft/: mode resolution (modes.py: FTTestMode / resolve_mode / parallelism configs), training execution (execution.py: get_common_train_args / get_ft_args / prepare / run_training), and the comparison app driver (app.py: create_comparison_app_and_run_ci / resolve_dump_dir) plus the package README. All FT e2e scenarios build on this harness.