Skip to content

Always save rollout debug data regardless of rollout_global_dataset #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fzyzcjy wants to merge 1 commit into
base: tom/pr_chain/trainer_ft/dev_revert_reversed/start-http-control-server-and-mini-ft-controller-in-train-entrypoints
Choose a base branch
from
+2 −4
Open

Always save rollout debug data regardless of rollout_global_dataset #1454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ async def save(rollout_id):
rollout_id,
force_sync=rollout_id == args.num_rollout - 1,
)
if args.rollout_global_dataset:
await rollout_manager.save.remote(rollout_id)
await rollout_manager.save.remote(rollout_id)

# train loop.
# note that for async training, one can change the position of the sync operation(ray.get).
Expand Down
3 changes: 1 addition & 2 deletions train_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ async def train(args):
rollout_id,
force_sync=rollout_id == args.num_rollout - 1,
)
if args.rollout_global_dataset:
await rollout_manager.save.remote(rollout_id)
await rollout_manager.save.remote(rollout_id)

if (rollout_id + 1) % args.update_weights_interval == 0:
# sync generate before update weights to prevent update weight in the middle of generation
Expand Down
Loading