Always save rollout debug data regardless of rollout_global_dataset#1454
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/start-http-control-server-and-mini-ft-controller-in-train-entrypoints
branch
from
4035227 to
99aafed
Compare
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/always-save-rollout-debug-data-regardless-of-rollout-global-dataset
branch
from
18f5d29 to
9bbb879
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/start-http-control-server-and-mini-ft-controller-in-train-entrypoints
branch
from
99aafed to
65789ef
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/always-save-rollout-debug-data-regardless-of-rollout-global-dataset
branch
from
9bbb879 to
19a080a
Compare
Drops the args.rollout_global_dataset guard around rollout_manager.save in train.py and train_async.py so rollout debug data is always persisted. FT comparison e2e tests rely on the dumped rollout data being present even when rollout_global_dataset is off.
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/start-http-control-server-and-mini-ft-controller-in-train-entrypoints
branch
from
65789ef to
097941c
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/always-save-rollout-debug-data-regardless-of-rollout-global-dataset
branch
from
19a080a to
b635d82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the args.rollout_global_dataset guard around rollout_manager.save in train.py and train_async.py so rollout debug data is always persisted. FT comparison e2e tests rely on the dumped rollout data being present even when rollout_global_dataset is off.