Log train-group step-end and analysis events#1447
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/inject-witness-ids-into-the-megatron-forward-and-train-step
branch
from
5f53d76 to
3452825
Compare
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/log-train-group-step-end-and-analysis-events
branch
from
3ea44a1 to
5e07ca5
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/inject-witness-ids-into-the-megatron-forward-and-train-step
branch
from
3452825 to
fde57ba
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/log-train-group-step-end-and-analysis-events
branch
from
5e07ca5 to
2afae2a
Compare
Adds observability to RayTrainGroup: run the event analyzer at the start of each train() rollout, emit a TrainGroupStepEndEvent with per-cell outcomes after each attempt, and emit an InferenceEngineWeightChecksumEvent after update_weights (collected via rollout_manager.check_weights). Includes the matching unit tests. The witness-id and cell-reconfigure events are added with their own features.
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/inject-witness-ids-into-the-megatron-forward-and-train-step
branch
from
fde57ba to
a19935b
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/log-train-group-step-end-and-analysis-events
branch
from
2afae2a to
f8190b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds observability to RayTrainGroup: run the event analyzer at the start of each train() rollout, emit a TrainGroupStepEndEvent with per-cell outcomes after each attempt, and emit an InferenceEngineWeightChecksumEvent after update_weights (collected via rollout_manager.check_weights). Includes the matching unit tests. The witness-id and cell-reconfigure events are added with their own features.