Bracket Megatron actor methods with the with_logs decorator#1445
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/track-rollout-engine-connection-staleness-on-the-weight-updater
branch
from
7ea403c to
262aafe
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/bracket-megatron-actor-methods-with-the-with-logs-decorator
branch
from
b1f9980 to
01273a5
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/track-rollout-engine-connection-staleness-on-the-weight-updater
branch
from
262aafe to
9026454
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/bracket-megatron-actor-methods-with-the-with-logs-decorator
branch
from
01273a5 to
58e1819
Compare
Wrap the Megatron train-actor methods with the with_logs decorator and log the train advantage-computation event, so actor-side timing and the advantage computation both surface through the structured event log.
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/track-rollout-engine-connection-staleness-on-the-weight-updater
branch
from
9026454 to
5a01762
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/bracket-megatron-actor-methods-with-the-with-logs-decorator
branch
from
58e1819 to
46bf61a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the Megatron train-actor methods with the with_logs decorator and log
the train advantage-computation event, so actor-side timing and the
advantage computation both surface through the structured event log.