Kill failed cells immediately on execute failure#1443
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/wire-per-cell-heartbeat-health-monitoring-into-the-train-group
branch
from
67f82c7 to
9ab1b55
Compare
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/kill-failed-cells-immediately-on-execute-failure
branch
from
2dc18f2 to
b7af66c
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/wire-per-cell-heartbeat-health-monitoring-into-the-train-group
branch
from
9ab1b55 to
fe607f9
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/kill-failed-cells-immediately-on-execute-failure
branch
from
b7af66c to
05b41e1
Compare
Changes the per-cell failure contract: when an actor execute() raises, the cell is not only marked errored but also stopped and confirmed dead (ray.kill + probe), via the kill_on_failure path in RayTrainCell._execute_raw. Renames mark_errored_on_failure to kill_on_failure, makes stop_and_confirm_dead private, and drops the group's separate _kill_errored_cells_and_confirm_dead pre-reconfigure step (now redundant since failures self-kill). Health-check probes pass kill_on_failure=False so a stale heartbeat does not kill the cell. Updates the error-isolation tests accordingly.
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/wire-per-cell-heartbeat-health-monitoring-into-the-train-group
branch
from
fe607f9 to
5cd96c4
Compare
fzyzcjy
force-pushed
the
tom/pr_chain/trainer_ft/dev_revert_reversed/kill-failed-cells-immediately-on-execute-failure
branch
from
05b41e1 to
ef74253
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the per-cell failure contract: when an actor execute() raises, the cell is not only marked errored but also stopped and confirmed dead (ray.kill + probe), via the kill_on_failure path in RayTrainCell._execute_raw. Renames mark_errored_on_failure to kill_on_failure, makes stop_and_confirm_dead private, and drops the group's separate _kill_errored_cells_and_confirm_dead pre-reconfigure step (now redundant since failures self-kill). Health-check probes pass kill_on_failure=False so a stale heartbeat does not kill the cell. Updates the error-isolation tests accordingly.