Skip to content

Conversation

@jon-the-dev
Copy link

Summary

Initial pass of adding AWS SAM to Runway

Why This Is Needed

AWS SAM is a more native solution for AWS Lambda and API Gateway solutions

What Changed

  • Added AWS SAM
  • Added tests & Docs

Added

  • AWS SAM Functionality

Changed

No

Screenshots

  • TBD

Checklist

  • Have you followed the guidelines in our Contribution Requirements?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?
  • Have you linted your code locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you updated documentation, as applicable?

@github-actions github-actions bot added the feature Request or pull request for a new feature label Jul 2, 2025
@jon-the-dev jon-the-dev requested a review from mbordash2 July 4, 2025 01:22
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 75.16340% with 38 lines in your changes missing coverage. Please review.

Project coverage is 90.26%. Comparing base (0d5a358) to head (c2d6f43).

Files with missing lines Patch % Lines
runway/module/sam.py 72.13% 34 Missing ⚠️
runway/_cli/commands/_gen_sample/_sam.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2880      +/-   ##
==========================================
- Coverage   90.41%   90.26%   -0.16%     
==========================================
  Files         231      234       +3     
  Lines       14943    15094     +151     
==========================================
+ Hits        13511    13624     +113     
- Misses       1432     1470      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Remove unused imports (os, subprocess, tempfile) from sam.py
- Move Path import to TYPE_CHECKING block
- Replace string join with direct string literal
- Replace list concatenation with unpacking
- Fix quote escaping in test files
- Add missing __init__.py for hello_world package
- Fix type annotations and docstring formatting in template
- Rename duplicate test method to avoid conflicts
- Add noqa comments for intentionally unused function arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Request or pull request for a new feature

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants