add hook args lookup resolution with a test and doc updates #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troyready
reviewed
Feb 10, 2020
runway/cfngin/hooks/utils.py
Outdated
| # from runway.variables import Variable, resolve_variables | ||
|
|
||
| from ..exceptions import FailedVariableLookup | ||
| # TODO replace after https://github.com/onicagroup/runway/pull/116 |
There was a problem hiding this comment.
@ITProKyle merged ^ and ready for updating
|
Not sure what to make of the disttools error in travis -- is it apparent to you? |
|
looking into it. nothing changed for us on that front so possibly a new version of something broke it. |
|
@troyready - fixed the build error (caused by a new version of |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation from cloudtools/stacker#708