Show entire error message #179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfindler
force-pushed
the
show-entire-error-message
branch
from
2a343a2 to
18a0eb9
Compare
|
I see that this is causing some test cases to fail, probably because they're checking the precise content of the error messages so probably the expected results need to be audited and adjusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to improve the error messages when rackunit catches an exception and decides that a test failed because of the caught exception.
Before this commit, rackunit would show only the basic message in the exception. Afterwards, it uses the error display handler, which can include a bunch more useful information (notably stack traces and information about syntax errors)