feat: PUC-740: comparing data from Openstack and Nautobot #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haseebsyed12
force-pushed
the
puc-740-diffsync
branch
3 times, most recently
from
666e478 to
c1f4c73
Compare
haseebsyed12
changed the title
cardoe
reviewed
Jan 24, 2025
python/diff-nautobot-understack/diff_nautobot_understack/project/adapters/openstack_project.py
Outdated
Show resolved
Hide resolved
python/diff-nautobot-understack/diff_nautobot_understack/clients/openstack.py
Outdated
Show resolved
Hide resolved
python/diff-nautobot-understack/diff_nautobot_understack/clients/openstack.py
Outdated
Show resolved
Hide resolved
stevekeay
reviewed
Jan 28, 2025
python/diff-nautobot-understack/diff_nautobot_understack/network/adapters/ucvni.py
Show resolved
Hide resolved
haseebsyed12
force-pushed
the
puc-740-diffsync
branch
from
9712389 to
a25859c
Compare
|
It would be good to write in the PR body what this is good for and achieves. We'll want to enable a bunch of lints as well. |
haseebsyed12
force-pushed
the
puc-740-diffsync
branch
from
a25859c to
31e9599
Compare
cardoe
requested changes
Feb 3, 2025
haseebsyed12
force-pushed
the
puc-740-diffsync
branch
from
5c32e53 to
62d5f27
Compare
nicholaskuechler
requested changes
Feb 10, 2025
haseebsyed12
force-pushed
the
puc-740-diffsync
branch
2 times, most recently
from
77f9a4b to
0eabd5e
Compare
cardoe
force-pushed
the
puc-740-diffsync
branch
2 times, most recently
from
7cc741f to
7f8f08f
Compare
cardoe
reviewed
Mar 1, 2025
haseebsyed12
force-pushed
the
puc-740-diffsync
branch
2 times, most recently
from
86d62b7 to
70e5844
Compare
cardoe
approved these changes
Mar 3, 2025
|
It's still backwards. The source of truth is OpenStack. So the source in diffsync should be openstack, not nautobot; and the destination should be nautobot, not openstack. |
haseebsyed12
force-pushed
the
puc-740-diffsync
branch
from
70e5844 to
5abdb7b
Compare
nicholaskuechler
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nautobot vs OpenStack Comparison Tool
This tool compares data between Nautobot and OpenStack.
Currently Supported Comparisons
Output from this tool for network comparision
