Adapt to the new standard library directory layout #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
approved these changes
Sep 4, 2020
|
Thanks!
Since it is not very difficult to try both of pathes, I'll add some fallbacks for macros and premitives later. |
|
Just tested this on Windows and the first run seem to have failed but other subsequent |
Leorii
reviewed
Sep 16, 2020
| @@ -4,8 +4,8 @@ use crate::nameres::{self, RUST_SRC_PATH}; | |||
| use rustc_ast::ast::{IntTy, LitIntType, UintTy}; | |||
| use std::path::PathBuf; | |||
|
|
|||
| const PRIM_DOC: &str = "libstd/primitive_docs.rs"; | |||
There was a problem hiding this comment.
Changing this to the new directory layout without also checking for the old layout will cause panics on any system that still has the old directory layout.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: rust-lang/rust#73265
@kngwyu Does that look acceptable? I'm somewhat torn where should I add a new fallback and where I should just straight up replace the old path logic. I think it makes sense to wholly replace it since Racer is tied to the version of Rust that distributes the rustc-ap-* library set it depends on but I'm not sure how much we'd like to maintain backwards-compat for older Rust toolchains...