edited Path #2
Open
edited Path #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your proposed change will break the Editor on how it's being hosted on GitHub pages. It needs the path to ensure it loads within the browser. Could you please explain in more detail what issue you encounter with GitHub pages? Does this have to do with hosting the Editor on a private repository using GitHub pages, that does not seem to support a path like 'dettect-editor'? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the good work.
I noticed that you can't use the editor with github or gitlab pages.
In relate to Issue #43, if you change the path in the links acordingly it would work with github pages.