-
Notifications
You must be signed in to change notification settings - Fork 4k
Allow configuring per-mount-point per-queue-type disk alarms #14815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
the-mikedavis
wants to merge
15
commits into
rabbitmq:main
Choose a base branch
from
amazon-mq:mount-point-limits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+799
−341
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ed05953
Allow configuring osiris data_dir in Cuttlefish config
the-mikedavis ebf055d
Allow configuring classic queue data dir in Cuttlefish config
the-mikedavis 16ac110
rabbit_stream_queue: Enable recovery after registering queue type
the-mikedavis 2097ed5
rabbit_alarm: Prefer maps to dicts
the-mikedavis adabdb2
rabbit_env: Enable disksup in os_mon but set threshold to 1.0
the-mikedavis 300ff60
rabbit_disk_monitor: Use disksup to determine available bytes
the-mikedavis e735f57
rabbit.schema: Add config options for per-queue-type disk limits
the-mikedavis 6d267e8
rabbit_disk_monitor: Monitor per-queue-type mounts
the-mikedavis 23ee1d5
rabbit_alarm: Add a helper to format resource alarm sources
the-mikedavis e1ac9d5
Set per-queue-type disk alarms for configured mounts
the-mikedavis 5aeb92e
AMQP 0-9-1: Handle per-queue-type disk alarms
the-mikedavis 1145d8e
prometheus: Add core metrics per-mount for free space and limit
the-mikedavis eca7e05
management: Expose current mount stats in API and UI
the-mikedavis 215ea6f
rabbit_disk_monitor: Add config to tune polling interval
the-mikedavis 44016e6
CLI: Extend set_disk_free_limit to set mount limits
the-mikedavis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature might need a feature flag. Here for direct connections if old client code is used on a newer server then it would error after publishing since it isn't expecting this cast. I think it would be unlikely to happen in practice but the mixed-version test suite will probably run into this.