Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake on rabbitmq_mqtt auth_SUITE #13180

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarcialRosales
Copy link
Contributor

Proposed Changes

Separate invalid client test from the valid one onto separate group and this way they use different SSL certs

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this Jan 30, 2025
@MarcialRosales MarcialRosales requested a review from ansd January 31, 2025 08:32
Copy link
Member

@ansd ansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails

@MarcialRosales
Copy link
Contributor Author

This fix was only for the flake on the mqtt auth_SUITE ... I cannot see any test suite related to mqtt or mqtt's auth_SUITE failing besides the dialyzer suite.
I have noticed though that the selenium test is failing. The change done on this PR is totally unrelated. I am looking at this selenium failure now locally. I have run it two times in CI and it is failing in the same test.

@MarcialRosales MarcialRosales force-pushed the fix-flake-on-mqtt-auth branch 2 times, most recently from aee5ef9 to 231ee93 Compare February 4, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants