-
Notifications
You must be signed in to change notification settings - Fork 8
Stream filters: Filter for message properties #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
based on message properites. Closes: #42 Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements message property filtering for stream consumers in the RabbitMQ AMQP Python client. The changes add support for filtering messages based on AMQP message properties like subject and group_id.
- Added
MessagePropertiesdataclass to define AMQP message properties for filtering - Extended
StreamFilterOptionsto include message properties filtering capability - Added comprehensive test coverage for the new filtering functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_streams.py | Adds test case and message handler for message properties filtering |
| rabbitmq_amqp_python_client/entities.py | Implements MessageProperties dataclass and extends filtering logic |
| rabbitmq_amqp_python_client/init.py | Exports new MessageProperties and StreamFilterOptions classes |
| examples/streams_with_filters/example_streams_with_filters.py | Provides usage example combining filter values and message properties |
| examples/README.md | Documents the new filtering example |
| Makefile | Adds mypy type checking to the format target |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
|
MErged per conversation with @Zerpet |
based on message properites. Closes: #42