Skip to content

Conversation

@Gsantomaggio
Copy link
Member

based on message properites. Closes: #42

based on message properites. Closes: #42

Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio added the enhancement New feature or request label Sep 12, 2025
@Gsantomaggio Gsantomaggio added this to the 0.2.0 milestone Sep 12, 2025
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
Signed-off-by: Gabriele Santomaggio <[email protected]>
@Gsantomaggio Gsantomaggio marked this pull request as ready for review September 12, 2025 11:50
@Zerpet Zerpet requested a review from Copilot September 12, 2025 11:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements message property filtering for stream consumers in the RabbitMQ AMQP Python client. The changes add support for filtering messages based on AMQP message properties like subject and group_id.

  • Added MessageProperties dataclass to define AMQP message properties for filtering
  • Extended StreamFilterOptions to include message properties filtering capability
  • Added comprehensive test coverage for the new filtering functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/test_streams.py Adds test case and message handler for message properties filtering
rabbitmq_amqp_python_client/entities.py Implements MessageProperties dataclass and extends filtering logic
rabbitmq_amqp_python_client/init.py Exports new MessageProperties and StreamFilterOptions classes
examples/streams_with_filters/example_streams_with_filters.py Provides usage example combining filter values and message properties
examples/README.md Documents the new filtering example
Makefile Adds mypy type checking to the format target

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Gsantomaggio Gsantomaggio merged commit 4146b5f into main Sep 12, 2025
1 check passed
@Gsantomaggio
Copy link
Member Author

MErged per conversation with @Zerpet

@Gsantomaggio Gsantomaggio deleted the feat/property_filters branch September 12, 2025 12:07
@Gsantomaggio Gsantomaggio changed the title Implement filters Stream filters: Filter for message properties Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stream filters: Filter for application-properties and properties

1 participant