Skip to content

Auth integration #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 26, 2025
Merged

Auth integration #57

merged 7 commits into from
Mar 26, 2025

Conversation

@DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented Mar 18, 2025 •
edited
Loading

This PR closes #46

  • Improve github ci to run the RabbitMQ server with oauth enabled
  • Implements oauth connections and refresh_token
  • Add an oauth example

@DanielePalaia DanielePalaia marked this pull request as draft March 18, 2025 08:58
@DanielePalaia DanielePalaia force-pushed the oauth branch 6 times, most recently from 26e8916 to 8438821 Compare March 18, 2025 09:56
@DanielePalaia DanielePalaia force-pushed the oauth branch 5 times, most recently from caace90 to cca4b54 Compare March 19, 2025 09:14
@DanielePalaia DanielePalaia changed the title improving automation Auth integration Mar 19, 2025
@DanielePalaia DanielePalaia force-pushed the oauth branch 6 times, most recently from 8672e47 to 578bff9 Compare March 19, 2025 13:51
@Gsantomaggio
Fix (#58)
2651308 
* Fix

Signed-off-by: Gabriele Santomaggio <[email protected]>

* formatting

---------

Signed-off-by: Gabriele Santomaggio <[email protected]>
Co-authored-by: Daniele <[email protected]>
@DanielePalaia DanielePalaia force-pushed the oauth branch 5 times, most recently from a50346e to 2771d96 Compare March 24, 2025 13:28
@DanielePalaia DanielePalaia force-pushed the oauth branch 5 times, most recently from eb968be to fc6df3e Compare March 24, 2025 14:10
@DanielePalaia DanielePalaia marked this pull request as ready for review March 25, 2025 09:14
@DanielePalaia
Copy link
Contributor Author

@Gsantomaggio I think we can start review this one!

Gsantomaggio
Gsantomaggio requested changes Mar 25, 2025
View reviewed changes
Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.

Also, do you think it is hard to add a test like this: https://github.com/rabbitmq/rabbitmq-amqp-dotnet-client/blob/main/Tests/OAuth2Tests.cs#L104-L136 ?

@DanielePalaia
Copy link
Contributor Author

@Gsantomaggio Done!

@DanielePalaia DanielePalaia merged commit 2317658 into main Mar 26, 2025
1 check passed
@DanielePalaia DanielePalaia deleted the oauth branch March 26, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gsantomaggio Gsantomaggio Gsantomaggio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement AMQP 1.0: support JWT (OAuth 2) #23

3 participants

@DanielePalaia @Gsantomaggio