Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto install git-theta when doing a track as people often forget this step #232

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

blester125
Copy link
Collaborator

@blester125 blester125 commented Feb 26, 2024

related to #229

@blester125 blester125 requested a review from nkandpa2 February 26, 2024 18:30
@craffel
Copy link
Contributor

craffel commented Feb 26, 2024

Hmm, for some reason I was thinking you'd fail out or warn or prompt the user rather than just doing a transparent install. I'd be a bit worried about this being a hidden side-effect, but I defer to you.

@blester125
Copy link
Collaborator Author

Hmm, for some reason I was thinking you'd fail out or warn or prompt the user rather than just doing a transparent install. I'd be a bit worried about this being a hidden side-effect, but I defer to you.

That is what I was planning to do, but I realized there are like 5 different possible places where the configuration for git-theta could be stored. We don't currently support setting it any place but ~/.gitconfig so I figured we would want to support setting it in those places in addition to checking them. So this solution seems to be a good stop-gap for a new user creating a new repo until we support the finer-grained settings.

I'm going to now close this issue and instead list it as an enhancement and expand on where to check for files and what not and link it in a new (enhancement) issue about supporting finer grained config files.

@blester125 blester125 force-pushed the chore/check-install branch 2 times, most recently from c17f675 to ea9c32c Compare April 22, 2024 15:53
@blester125
Copy link
Collaborator Author

Updated, now checking if git theta is installed will check all possible locations for an install (based on the git config --list command. So we don't need to worry about how they installed it so we don't have to run a global install each time.

@blester125
Copy link
Collaborator Author

closes #229

@blester125 blester125 linked an issue Apr 22, 2024 that may be closed by this pull request
@blester125 blester125 force-pushed the chore/check-install branch from ea9c32c to 45e3a47 Compare April 24, 2024 20:38
@blester125 blester125 merged commit 019e124 into r-three:main Apr 24, 2024
19 checks passed
@blester125 blester125 deleted the chore/check-install branch April 24, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method to tell if git-theta wasn't installed?
2 participants